Note that unlike the `class` variables, these specs didn't contain the
`(min-colors 89)` element. I assumed this was unintentional, but if not,
ignore this commit.
These represent display lists like the `class` variable currently does,
but with an added element specifying the background variant. These can
be used just like `class` currently is to specify a face spec for a
particular background variant.
The old face `git-commit-comment-branch' was replaced
with two new faces `git-commit-comment-branch-local'
and `git-commit-comment-branch-remote'.
Keep the old face around for a while until "everyone"
has updated, but at least until the next `git-commit'
release.
Collect all faces whose Custom group is `basic-faces' in the very
first section that contains face definitions.
Actually there is one except - `isearch' is placed in the "isearch"
section because another Isearch face is being themed by this theme
and that face (like all other Isearch faces except `isearch') are
only members of the `isearch' group, but not of `basic-faces'. So
this inconsistency in Solarized is due to an inconsistency in Emacs.
Note that Solarized does not theme the following members of the
`basic-faces' group:
- `bold'
- `bold-italic'
- `border'
- `fixed-pitch'
- `fixed-pitch-serif'
- `glyphless-char'
- `italic'
- `mode-line-emphasis'
- `mode-line-highlight'
- `mouse'
- `nobreak-space'
- `scroll-bar'
- `tool-bar'
- `tool-tips'
- `tty-menu-enabled'
- `tty-menu-selected'
- `underline'
- `variable-pitch'
- `window-divider'
- `window-divider-first-pixel'
- `window-divider-last-pixel'
Doing so would make the complete heading bold, but we only want the
parts to be bold that are already bold anyway, and they continue to
do be even if we don't explicitly say that it should be so.
This theme targets Emacs 24, so it can simply directly use the
color-name-to-rgb and color-rgb-to-hex, since those functions have been
available in color.el since Emacs 24.1. In fact, the code removed by
this commit has apparently been copied-and-pasted from there, and
prefixed with "solarized-".
When saving customisation after enabling this theme, the saved settings for certain variables (e.g. the highlight symbol faces) get set to forms which reference solarized-color-blend. If the saved theme is later switched to a different theme, then those variables settings break, because solarized will not be loaded at the time they are evaluated.
See https://github.com/pidu/git-timemachine for information about
git-timemachine.
I picked the colours for no other reason than that git-timemachine
itself uses "orange" and "yellow" respectively for these faces.
