yogsototh/kibit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
260 commits 1 branch 3 tags 318 KiB
Commit graph

260 commits

This branch
This branch
All branches
Author SHA1 Message Date
Bjarte Johansen
cba0a329a8 Remove do binding in loop form 
loop provides implicit do form in construct.
 2012-10-18 14:51:26 +02:00
Jonas Enlund
e1845b6ef0 Revert "Merge pull request #55 from edtsech/if-true-or" 
This reverts commit 72432a0764, reversing
changes made to 25cf9d92ae.
 2012-10-16 17:33:01 +03:00
Jonas Enlund
72432a0764 Merge pull request #55 from edtsech/if-true-or 
Rule for (if test true else).
 2012-10-16 05:46:27 -07:00
Edward Tsech
7428264f7f Rule for (if test true else). 2012-10-16 11:36:09 +02:00
Jonas Enlund
25cf9d92ae Merge pull request #51 from ljos/master 
Do forms are unneccesary in let forms.
 2012-09-20 06:39:38 -07:00
Bjarte Johansen
24ff7fd6ea Remove do binding in let form 
do binding in let form is not neccessary as let provides an implicit do
form.
 2012-09-20 12:06:49 +02:00
Jonas Enlund
b085c01c4f Added 'repeatedly' rule as suggested in issue #48 2012-08-25 20:27:31 +03:00
Jonas Enlund
37b2a6c62c Merge pull request #47 from sjl/master 
(update-in ... assoc ...) to (assoc-in ...)
 2012-07-14 11:50:37 -07:00
Steve Losh
c450d1da60 (update-in ... assoc ...) should be (assoc-in ...) 2012-07-14 14:47:18 -04:00
Jonas Enlund
176841cb4a Merge pull request #46 from sjl/master 
update-in suggestions
 2012-07-11 07:34:41 -07:00
Steve Losh
b270b09a9e Add update-in suggestions. 
I often forget that update-in exists.  This change adds a rule to remind people
of it for a few simple cases.
 2012-07-10 17:25:27 -04:00
Jonas Enlund
9f4af6ef87 Merge pull request #45 from miner/master 
another empty? recommendation
 2012-07-10 00:10:46 -07:00
Steve Miner
d68221fdcc (when-not (empty? x) body) should be (when (seq x) body) 2012-07-09 17:45:17 -04:00
Jonas Enlund
a34d5c45b1 Merge pull request #44 from miner/master 
prefer (seq x) over (not (empty? x)
 2012-07-08 13:15:55 -07:00
Steve Miner
cc83a68c1b prefer (seq x) over (not (empty? x)) 2012-07-08 16:01:04 -04:00
Jonas Enlund
dacbdd14f2 Merge pull request #43 from duelinmarkers/fix-dot-rule-when-member-is-a-list 
Handle list member-access in dot form. Fixes #33.
 2012-06-26 08:21:47 -07:00
Jonas Enlund
66b318bd42 Merge pull request #42 from duelinmarkers/issue-39 
Fix 'remove suggestion for 'filter with anonymous fn
 2012-06-26 08:21:01 -07:00
Jonas Enlund
7a4d2bfc50 fixed readme 2012-06-11 07:47:18 +03:00
Jonas Enlund
5f3fc0cff0 Mention limitations in README 2012-06-11 07:43:23 +03:00
Jonas Enlund
af21ab3e81 Merge pull request #40 from duelinmarkers/test-coverage-for-rules 
Test coverage for rules
 2012-06-10 21:20:06 -07:00
John Hume
2a899b452a Handle list member-access in dot form. Fixes #33. 2012-06-10 23:03:48 -04:00
John Hume
c45be0724b Fix 'remove suggestion for anonymous fns, issue #39. 2012-06-10 21:39:22 -04:00
John Hume
c6238ac337 Remove extra whitespace 2012-06-10 21:26:11 -04:00
John Hume
3bb4ad5c71 Remove redundant [(not (= x y)) (not= x y)] 
The rule is already covered in equality.
 2012-06-10 21:13:38 -04:00
John Hume
1f66ea8f5a Remove redundant [(do x) x] 
The rule is covered in control-structures.
 2012-06-10 21:12:38 -04:00
John Hume
d7dc246e99 Add minimal test coverage for all rules 2012-06-10 21:04:43 -04:00
John Hume
3b5cac7c86 More complete test coverage for control-structures 
This covers all but the (loop [] ...) rule, which seems to include the
(recur) in the body of the suggested (when...) form.
 2012-06-10 19:29:14 -04:00
Jonas Enlund
75b4091ebb Merge pull request #38 from tsdh/master 
Here's the requested emacs-usage documentation in the README.md.
 2012-05-31 06:40:57 -07:00
Tassilo Horn
3a2e85200a Document Emacs usage in README.md 2012-05-31 15:38:50 +02:00
Jonas Enlund
710e67188a Merge pull request #37 from tsdh/master 
Use check-file instead of check-reader.
 2012-05-31 06:30:25 -07:00
Tassilo Horn
abf4979a0f Use check-file instead of check-reader. 
Also, make check-file include :file metadata.  Show that including the line
number in a more conventional compiler output format, which can be easily
exploited by tools such as Emacs.

For example, the following implements kibit support for Emacs, i.e., M-x kibit
RET will run kibit in the current project and show its results in a
*compilation* buffer, where all kibit suggestions are properly highlighted and
hyperlinked to the clojure source code files.

---------------------------------------------------------------
(require 'compile)

(add-to-list 'compilation-error-regexp-alist-alist
	     '(kibit "At \\([^:]+\\):\\([[:digit:]]+\\):" 1 2 nil 0))

(add-to-list 'compilation-error-regexp-alist 'kibit)

(defun kibit ()
  "Run kibit on the current project.
Display the results in a hyperlinked *compilation* buffer."
  (interactive)
  (compile "lein kibit"))
---------------------------------------------------------------
 2012-05-31 11:29:40 +02:00
Jonas Enlund
388afa57b8 Merge pull request #36 from tsdh/master 
Suggest `while` for bindingless loop-recur
 2012-05-30 07:53:15 -07:00
Tassilo Horn
7f9c5281d8 suggest while for bindingless loop-recur 2012-05-30 15:40:58 +02:00
Jonas Enlund
976dff31b9 Merge pull request #35 from tsdh/master 
Suggest shorthands for the first/next combinations
 2012-05-30 06:37:51 -07:00
Tassilo Horn
75ff91ad10 add me to contributors 2012-05-30 14:55:12 +02:00
Tassilo Horn
9a021e8885 Suggest shorthands of first/next combinations. 2012-05-30 14:53:13 +02:00
Jonas Enlund
ebb2ffe92e Release 0.0.4 2012-05-20 08:20:25 +03:00
Jonas Enlund
0f6bbc689a fixed issue #31 2012-05-20 08:12:05 +03:00
Jonas Enlund
820d26ad0b Fixed (if ?x (do . ?y)) rule (#32) 2012-05-19 17:21:08 +03:00
Jonas Enlund
2e1f33379e Bump version to 0.0.4-SNAPSHOT 2012-04-03 17:46:00 +03:00
Jonas Enlund
dc4f723baa Added not-any? rule 2012-04-02 22:24:36 +03:00
Jonas Enlund
65095fc3b5 Fixed anononymous function rule -- fixes #29 2012-04-02 22:09:17 +03:00
Jonas Enlund
d483dae7aa Removed old threading rule 2012-04-02 07:17:50 +03:00
Jonas Enlund
41b6c53964 Fixed threading rules 2012-04-02 06:42:22 +03:00
Jonas Enlund
095c23f336 Update README.md 2012-04-01 21:56:28 +03:00
Jonas Enlund
4734a1ba40 Release 0.0.3 2012-04-01 19:44:26 +03:00
Jonas Enlund
9be5f26fd9 Added two 'raw' rules 2012-04-01 14:09:49 +03:00
Jonas Enlund
7513c744b1 New rule system 2012-04-01 07:39:39 +03:00
Jonas Enlund
308e638ba6 Fixed the plugin, removed plugin opts for now 2012-03-28 16:11:34 +03:00
Paul deGrandis
337da5049a Merge branch 'simplifying-core-paul' 2012-03-27 12:45:26 -04:00