yogsototh/kibit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add update-in suggestions.

Browse source 
I often forget that update-in exists.  This change adds a rule to remind people
of it for a few simple cases.
This commit is contained in:
Steve Losh 2012-07-10 17:25:27 -04:00
parent 9f4af6ef87
commit b270b09a9e
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/kibit/rules/collections.clj
View file

@ -5,6 +5,9 @@
;;vector
[(conj [] . ?x) (vector . ?x)]
[(into [] ?coll) (vec ?coll)]
[(assoc ?coll ?key (?fn (?key ?coll) . ?args)) (update-in ?coll [?key] ?fn . ?args)]
[(assoc ?coll ?key (?fn (?coll ?key) . ?args)) (update-in ?coll [?key] ?fn . ?args)]
[(assoc ?coll ?key (?fn (get ?coll ?key) . ?args)) (update-in ?coll [?key] ?fn . ?args)]
;; empty?
[(not (empty? ?x)) (seq ?x)]

8
test/kibit/test/collections.clj
View file

@ -11,4 +11,10 @@
'(vector a) '(conj [] a)
'(vector a b) '(conj [] a b)
'(vec coll) '(into [] coll)
'(set coll) '(into #{} coll)))
'(set coll) '(into #{} coll)
'(update-in coll [k] f) '(assoc coll k (f (k coll)))
'(update-in coll [k] f) '(assoc coll k (f (coll k)))
'(update-in coll [k] f) '(assoc coll k (f (get coll k)))
'(update-in coll [k] f a b c) '(assoc coll k (f (k coll) a b c))
'(update-in coll [k] f a b c) '(assoc coll k (f (coll k) a b c))
'(update-in coll [k] f a b c) '(assoc coll k (f (get coll k) a b c))))