From f6900a362614ebf825ad3f83fc87bc6edb9fc419 Mon Sep 17 00:00:00 2001 From: Sebastian Wiesner Date: Tue, 21 May 2013 16:57:58 +0200 Subject: [PATCH] Use wave underlines for Fly(make|check|spell) if possible MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Wave underlines are available as of Emacs 24.3. These underlines are much less intrusive than foreground faces, and thus better suited to highlight “background” errors from on-the-fly syntax or spell checking. Using such underlines also makes this theme adhere to the standard user interface of spell checkers or syntax checkers in other editors or IDEs. --- solarized.el | 31 ++++++++++++++++++++++++------- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/solarized.el b/solarized.el index 455f100..1726628 100644 --- a/solarized.el +++ b/solarized.el @@ -362,24 +362,41 @@ ;; flymake `(flymake-errline - ((,class (:foreground ,red-hc :background ,red-lc :weight bold :underline t)))) - `(flymake-infoline ((,class (:foreground ,green-hc :background ,green-lc)))) + ((,(append '((supports :underline (:style wave))) class) + (:underline (:style wave :color ,red))) + (,class (:foreground ,red-hc :background ,red-lc :weight bold :underline t)))) + `(flymake-infoline + ((,(append '((supports :underline (:style wave))) class) + (:underline (:style wave :color ,green))) + (,class (:foreground ,green-hc :background ,green-lc)))) `(flymake-warnline - ((,class (:foreground ,yellow-hc :background ,yellow-lc :weight bold :underline t)))) + ((,(append '((supports :underline (:style wave))) class) + (:underline (:style wave :color ,yellow))) + (,class (:foreground ,yellow-hc :background ,yellow-lc :weight bold :underline t)))) ;; flycheck `(flycheck-error - ((,class (:foreground ,red-hc :background ,red-lc :weight bold :underline t)))) + ((,(append '((supports :underline (:style wave))) class) + (:underline (:style wave :color ,red))) + (,class (:foreground ,red-hc :background ,red-lc :weight bold :underline t)))) `(flycheck-warning - ((,class (:foreground ,yellow-hc :background ,yellow-lc :weight bold :underline t)))) + ((,(append '((supports :underline (:style wave))) class) + (:underline (:style wave :color ,yellow))) + (,class (:foreground ,yellow-hc :background ,yellow-lc :weight bold :underline t)))) `(flycheck-fringe-error ((,class (:foreground ,red-hc :background ,red-lc :weight bold)))) `(flycheck-fringe-warning ((,class (:foreground ,yellow-hc :background ,yellow-lc :weight bold)))) ;; flyspell - `(flyspell-duplicate ((,class (:foreground ,yellow :weight bold :underline t)))) - `(flyspell-incorrect ((,class (:foreground ,red :weight bold :underline t)))) + `(flyspell-duplicate + ((,(append '((supports :underline (:style wave))) class) + (:underline (:style wave :color ,yellow))) + (,class (:foreground ,yellow :weight bold :underline t)))) + `(flyspell-incorrect + ((,(append '((supports :underline (:style wave))) class) + (:underline (:style wave :color ,red))) + (,class (:foreground ,red :weight bold :underline t)))) ;; erc `(erc-action-face ((,class (:inherit erc-default-face))))