(chore): remove org-roam-completion-fuzzy-match (#523)
Remove the fuzzy matching variable introduced in #289. The rationale is addressed in https://github.com/jethrokuan/org-roam/issues/514#issuecomment-619438401: Helm, Ido and Ivy have their own mechanisms for fuzzy search, and can be tweaked using their own configuration options outside of org-roam, e.g. through `ivy-re-builders-alist`.
This commit is contained in:
parent
bd3c97bb30
commit
487025aa2f
2 changed files with 5 additions and 10 deletions
|
@ -2,6 +2,9 @@
|
|||
|
||||
## 1.1.1 (TBD)
|
||||
|
||||
### Breaking Changes
|
||||
* [#523](https://github.com/jethrokuan/org-roam/pull/523) remove `org-roam-completion-fuzzy-match` in favor of using completion mechanism's configuration options directly
|
||||
|
||||
### Bugfixes
|
||||
* [#509](https://github.com/jethrokuan/org-roam/pull/509) fix backup files being tracked in database
|
||||
* [#509](https://github.com/jethrokuan/org-roam/pull/509) fix external org files being tracked in database
|
||||
|
|
|
@ -47,11 +47,6 @@
|
|||
(function :tag "Custom function"))
|
||||
:group 'org-roam)
|
||||
|
||||
(defcustom org-roam-completion-fuzzy-match nil
|
||||
"Whether to fuzzy match Org-roam's completion candidates."
|
||||
:type 'boolean
|
||||
:group 'org-roam)
|
||||
|
||||
(defun org-roam-completion--helm-candidate-transformer (candidates _source)
|
||||
"Transforms CANDIDATES for Helm-based completing read.
|
||||
SOURCE is not used."
|
||||
|
@ -82,9 +77,7 @@ Return user choice."
|
|||
:require-match require-match
|
||||
:action (prog1 action
|
||||
(setq action nil))
|
||||
:caller 'org-roam--completing-read
|
||||
:re-builder (if org-roam-completion-fuzzy-match 'ivy--regex-fuzzy
|
||||
'regexp-quote))
|
||||
:caller 'org-roam--completing-read)
|
||||
(user-error "Please install ivy from \
|
||||
https://github.com/abo-abo/swiper")))
|
||||
((eq org-roam-completion-system 'helm)
|
||||
|
@ -96,8 +89,7 @@ https://github.com/emacs-helm/helm"))
|
|||
:candidates (mapcar #'car choices)
|
||||
:filtered-candidate-transformer
|
||||
(and (not require-match)
|
||||
#'org-roam-completion--helm-candidate-transformer)
|
||||
:fuzzy-match org-roam-completion-fuzzy-match))
|
||||
#'org-roam-completion--helm-candidate-transformer)))
|
||||
(buf (concat "*org-roam "
|
||||
(s-downcase (s-chop-suffix ":" (s-trim prompt)))
|
||||
"*")))
|
||||
|
|
Loading…
Reference in a new issue