From 1cebb9a93b64af16ecbf0aa49b56eaca42b7e2c6 Mon Sep 17 00:00:00 2001 From: Phil Hagelberg Date: Mon, 18 Sep 2017 10:19:49 -0700 Subject: [PATCH] Add a comment explaining that the test task is a legacy monkeypatch. [skip ci] --- src/leiningen/test.clj | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/leiningen/test.clj b/src/leiningen/test.clj index 04aa8415..97d9dd2f 100644 --- a/src/leiningen/test.clj +++ b/src/leiningen/test.clj @@ -10,6 +10,18 @@ (def ^:dynamic *exit-after-tests* true) +;; This is a massive and terrible monkeypatch to work around the fact +;; that the built-in clojure.test library does not accept patches from +;; outside the core team. At this point the monkeypatching code below +;; should be considered legacy, and rather than trying to improve it, +;; all efforts should be instead directed towards improving external +;; libraries such as https://github.com/circleci/circleci.test, which +;; has a superset of these features and also doesn't require you to +;; stop using clojure.test to write your tests. + +;; We recommend that projects override the test task with an alias +;; that calls out to a third-party testing library instead. + (def form-for-suppressing-unselected-tests "A function that figures out which vars need to be suppressed based on the given selectors, moves their :test metadata to :leiningen/skipped-test (so