yogsototh/leiningen
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
leiningen/test_projects/managed-deps-snapshot/project.clj

27 lines
1.2 KiB
Clojure
Raw Normal View History

Fix checking for SNAPSHOT deps with managed deps - fixes #2205 This commit fixes #2205: when using managed dependencies in a project, if the project itself was a non-SNAPSHOT version, then when `lein install` and similar tasks were executed, lein would check to make sure that none of the dependencies were a SNAPSHOT version. lein was checking that directly against the `:dependencies` vector, which would cause an NPE if a dependency didn't specify a version number (because it was inheriting it from the `:managed-dependencies` section). This commit fixes the bug by calling the code that merges the `:dependencies` and `:managed-dependencies` vectors together prior to performing the SNAPSHOT check.
2016-09-16 04:06:03 +00:00
(def clj-version "1.3.0")
(defproject mgmt "0.99.0-SNAPSHOT"
:description "A test project"
:managed-dependencies [[~(symbol "org.clojure" "clojure") ~clj-version]
[rome ~(str "0." "9")]
[ring/ring "1.0.0"]
[ring/ring-codec "1.0.1"]
Don't require `nil` for version in managed deps - fixes #2195 Prior to this commit, if you wanted to use modifiers such as `:exclusions` or `:classifier` for a dependency whose version you were managing with `:managed-dependencies`, you would need to explicitly pass a `nil` as the version string in the dependency tuple. This commit adds some logic to coerce the vectors before they are processed, so that if the version string is simply omitted instead of being set to `nil`, the `nil` will be implicitly inserted and things will continue to work as before. This provides a slightly nicer and more intuitive UX for the managed-dependencies feature.
2016-09-16 22:07:40 +00:00
[ring/ring-headers "0.2.0"]
Fix checking for SNAPSHOT deps with managed deps - fixes #2205 This commit fixes #2205: when using managed dependencies in a project, if the project itself was a non-SNAPSHOT version, then when `lein install` and similar tasks were executed, lein would check to make sure that none of the dependencies were a SNAPSHOT version. lein was checking that directly against the `:dependencies` vector, which would cause an NPE if a dependency didn't specify a version number (because it was inheriting it from the `:managed-dependencies` section). This commit fixes the bug by calling the code that merges the `:dependencies` and `:managed-dependencies` vectors together prior to performing the SNAPSHOT check.
2016-09-16 04:06:03 +00:00
[commons-math/commons-math "1.2" :classifier "sources"]
Don't require `nil` for version in managed deps - fixes #2195 Prior to this commit, if you wanted to use modifiers such as `:exclusions` or `:classifier` for a dependency whose version you were managing with `:managed-dependencies`, you would need to explicitly pass a `nil` as the version string in the dependency tuple. This commit adds some logic to coerce the vectors before they are processed, so that if the version string is simply omitted instead of being set to `nil`, the `nil` will be implicitly inserted and things will continue to work as before. This provides a slightly nicer and more intuitive UX for the managed-dependencies feature.
2016-09-16 22:07:40 +00:00
[org.apache.commons/commons-csv "1.4" :classifier "sources"]
Fix checking for SNAPSHOT deps with managed deps - fixes #2205 This commit fixes #2205: when using managed dependencies in a project, if the project itself was a non-SNAPSHOT version, then when `lein install` and similar tasks were executed, lein would check to make sure that none of the dependencies were a SNAPSHOT version. lein was checking that directly against the `:dependencies` vector, which would cause an NPE if a dependency didn't specify a version number (because it was inheriting it from the `:managed-dependencies` section). This commit fixes the bug by calling the code that merges the `:dependencies` and `:managed-dependencies` vectors together prior to performing the SNAPSHOT check.
2016-09-16 04:06:03 +00:00
[ring/ring-defaults "0.2.1"]
[org.clojure/tools.reader "1.0.0-beta3"]]
:dependencies [[org.clojure/clojure]
[rome/rome nil]
[ring]
[ring/ring-codec nil :exclusions [commons-codec]]
Don't require `nil` for version in managed deps - fixes #2195 Prior to this commit, if you wanted to use modifiers such as `:exclusions` or `:classifier` for a dependency whose version you were managing with `:managed-dependencies`, you would need to explicitly pass a `nil` as the version string in the dependency tuple. This commit adds some logic to coerce the vectors before they are processed, so that if the version string is simply omitted instead of being set to `nil`, the `nil` will be implicitly inserted and things will continue to work as before. This provides a slightly nicer and more intuitive UX for the managed-dependencies feature.
2016-09-16 22:07:40 +00:00
[ring/ring-headers :exclusions [ring/ring-core]]
Fix checking for SNAPSHOT deps with managed deps - fixes #2205 This commit fixes #2205: when using managed dependencies in a project, if the project itself was a non-SNAPSHOT version, then when `lein install` and similar tasks were executed, lein would check to make sure that none of the dependencies were a SNAPSHOT version. lein was checking that directly against the `:dependencies` vector, which would cause an NPE if a dependency didn't specify a version number (because it was inheriting it from the `:managed-dependencies` section). This commit fixes the bug by calling the code that merges the `:dependencies` and `:managed-dependencies` vectors together prior to performing the SNAPSHOT check.
2016-09-16 04:06:03 +00:00
[commons-codec "1.6"]
[commons-math nil :classifier "sources"]
Don't require `nil` for version in managed deps - fixes #2195 Prior to this commit, if you wanted to use modifiers such as `:exclusions` or `:classifier` for a dependency whose version you were managing with `:managed-dependencies`, you would need to explicitly pass a `nil` as the version string in the dependency tuple. This commit adds some logic to coerce the vectors before they are processed, so that if the version string is simply omitted instead of being set to `nil`, the `nil` will be implicitly inserted and things will continue to work as before. This provides a slightly nicer and more intuitive UX for the managed-dependencies feature.
2016-09-16 22:07:40 +00:00
[org.apache.commons/commons-csv :classifier "sources"]
Fix checking for SNAPSHOT deps with managed deps - fixes #2205 This commit fixes #2205: when using managed dependencies in a project, if the project itself was a non-SNAPSHOT version, then when `lein install` and similar tasks were executed, lein would check to make sure that none of the dependencies were a SNAPSHOT version. lein was checking that directly against the `:dependencies` vector, which would cause an NPE if a dependency didn't specify a version number (because it was inheriting it from the `:managed-dependencies` section). This commit fixes the bug by calling the code that merges the `:dependencies` and `:managed-dependencies` vectors together prior to performing the SNAPSHOT check.
2016-09-16 04:06:03 +00:00
[org.clojure/tools.emitter.jvm "0.1.0-beta5"] ; depends on tools.reader 0.8.5
[org.clojure/tools.namespace "0.3.0-alpha3"] ; depends on tools.reader 0.10.0
])
Reference in a new issue Copy permalink