yogsototh/hglmandel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Better sentences.

Browse source
This commit is contained in:
Yann Esposito 2012-06-15 14:40:01 +02:00
parent ae6e6c3520
commit 4a61dbb8fc
2 changed files with 15 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
04_Mandelbulb/Mandelbulb.lhs
View file

@ -1,6 +1,6 @@
## Naïve code cleaning ## Naïve code cleaning
The first thing to do is to separate the GLUT/OpenGL The first approach to clean the code is to separate the GLUT/OpenGL
part from the computation of the shape. part from the computation of the shape.
Here is the cleaned version of the preceding section. Here is the cleaned version of the preceding section.
Most boilerplate was put in external files. Most boilerplate was put in external files.

29
06_Mandelbulb/Mandelbulb.lhs
View file

@ -1,14 +1,15 @@
## Optimization ## Optimization
From the architecture stand point all is clear. Our code architecture feel very clean.
All the meaningful code is in our main file and all display details are
externalized.
If you read the code of `YGL.hs`, you'll see I didn't made everything perfect. If you read the code of `YGL.hs`, you'll see I didn't made everything perfect.
For example, I didn't finished the code of the lights. For example, I didn't finished the code of the lights.
But I believe it is a good first step and it will be easy to go further. But I believe it is a good first step and it will be easy to go further.
The separation between rendering and world behavior is clear.
Unfortunately the program of the preceding session is extremely slow. Unfortunately the program of the preceding session is extremely slow.
We compute the Mandelbulb for each frame now. We compute the Mandelbulb for each frame now.
Before we had Before our program structure was:
<code class="no-highlight"> <code class="no-highlight">
Constant Function -> Constant List of Triangles -> Display Constant Function -> Constant List of Triangles -> Display
@ -17,18 +18,16 @@ Constant Function -> Constant List of Triangles -> Display
Now we have Now we have
<code class="no-highlight"> <code class="no-highlight">
World -> Function -> List of Objects -> Atoms -> Display Main loop -> World -> Function -> List of Objects -> Atoms -> Display
</code> </code>
And the World state could change. The World state could change.
Then it is no more straightforward for the compiler to understand The compiler can no more optimize the computation for us.
when not to recompute the entire list of atoms. We have to manually explain when to redraw the shape.
Then to optimize we will have to make things a little less separate. To optimize we must do some things in a lower level.
We must control the flow of atom generation. Mostly the program remains the same,
but it will provide the list of atoms directly.
Mostly the program is the same as before, but instead of providing a
function, we will provide the list of atoms directly.
<div style="display:none"> <div style="display:none">
@ -115,7 +114,6 @@ function, we will provide the list of atoms directly.
Our initial world state is slightly changed: Our initial world state is slightly changed:
> -- We initialize the world state > -- We initialize the world state
> -- then angle, position and zoom of the camera > -- then angle, position and zoom of the camera
> -- And the shape function > -- And the shape function
@ -134,6 +132,8 @@ Our initial world state is slightly changed:
> } > }
> where eps=2 > where eps=2
The use of `eps` is a hint to make a better zoom by computing with the right bounds.
We use the `YGL.getObject3DFromShapeFunction` function directly. We use the `YGL.getObject3DFromShapeFunction` function directly.
This way instead of providing `XYFunc`, we provide directly a list of Atoms. This way instead of providing `XYFunc`, we provide directly a list of Atoms.
@ -213,9 +213,8 @@ All the rest is exactly the same.
</div> </div>
And you can also consider small changes in other source files. And you can also consider minor changes in the `YGL.hs` source file.
- [`YGL.hs`](code/06_Mandelbulb/YGL.hs), the 3D rendering framework - [`YGL.hs`](code/06_Mandelbulb/YGL.hs), the 3D rendering framework
- [`Mandel`](code/06_Mandelbulb/Mandel.hs), the mandel function - [`Mandel`](code/06_Mandelbulb/Mandel.hs), the mandel function
- [`ExtComplex`](code/06_Mandelbulb/ExtComplex.hs), the extended complexes - [`ExtComplex`](code/06_Mandelbulb/ExtComplex.hs), the extended complexes