yogsototh/freactive
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix for disposing a ReactiveElement when it is detached from the tree (or moved) by some other method (say diffing).

Browse source
This commit is contained in:
Aaron Craelius 2014-11-27 12:43:31 -05:00
parent 9211bc8955
commit fda4d337fd
1 changed files with 13 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/clojure/freactive/dom.cljs
View file

@ -719,30 +719,29 @@
ref-meta (meta child-ref)
get-new-elem (fn []
get-new-elem (fn get-new-elem-fn []
(set! (.-dirty state) false)
(add-watch* child-ref state (.-invalidate state))
(or (non-reactively @child-ref) ""))
show-new-elem (fn [new-elem cur]
show-new-elem (fn show-new-elem-fn [new-elem cur]
(let [cur
(if (instance? ReactiveElement cur)
(let [cur-elem (.-cur-element cur)]
(set! (.-disposed cur) true)
(set! (.-cur-element cur) nil)
cur-elem)
cur)
new-node
(if cur
cur)]
(if-let [parent parent]
(let [new-node (if cur
(replace-child* parent new-elem cur true)
(insert-child* parent new-elem before))]
(set! (.-cur-element state) new-node)
(set! (.-updating state) false)
(when (.-dirty state)
(queue-animation (.-animate state)))
(show-node new-node)))
(show-node new-node))
(set! (.-disposed state) true))))
animate
(fn animate [x]