yogsototh/elm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix issue #230

Browse source 
The problem was that `inner` was not refering to the correct node in
the `setPos` expression if the inner node got replaced.
This commit is contained in:
Evan Czaplicki 2013-09-02 01:04:21 -07:00
parent 128e21db21
commit 984cfc55a9
1 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
runtime/Render/Element.js
View file

@ -124,6 +124,8 @@ function toPos(pos) {
}
}
// must clear right, left, top, bottom, and transform
// before calling this function
function setPos(pos,w,h,e) {
e.style.position = 'absolute';
e.style.margin = 'auto';
@ -220,18 +222,8 @@ function update(node, curr, next) {
}
break;
case "Container":
var inner = node.firstChild;
if (!update(inner, currE._1, nextE._1)) {
if (nextE._0.horizontal.ctor !== currE._0.horizontal.ctor) {
inner.style.left = inner.style.right = 'none';
removeTransform(inner.style);
}
if (nextE._0.vertical.ctor !== currE._0.vertical.ctor) {
inner.style.top = inner.style.bottom = 'none';
removeTransform(inner.style);
}
}
setPos(nextE._0, nextE._1.props.width, nextE._1.props.height, inner);
update(node.firstChild, currE._1, nextE._1)
setPos(nextE._0, nextE._1.props.width, nextE._1.props.height, node.firstChild);
break;
case "Custom":
if (currE.type === nextE.type) {