From e60b07e4e3de4516dd6f8a5dea0dd0f15f3dc3c4 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Fri, 5 Apr 2024 11:51:21 -0400 Subject: [PATCH] fix(julia): duplicate popup rules Having the same rule in two separate package configs means users must be aware of both to modify either, which is avoidable complexity. i.e. (after! (:or julia-repl julia-snail) (set-popup-rule! "^\\*julia" ...)) --- modules/lang/julia/config.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/lang/julia/config.el b/modules/lang/julia/config.el index 657574431..df34a47ae 100644 --- a/modules/lang/julia/config.el +++ b/modules/lang/julia/config.el @@ -53,7 +53,8 @@ :hook (+julia-repl-start . +julia-override-repl-escape-char-h) :hook (+julia-repl-start . julia-repl-use-emacsclient) :config - (set-popup-rule! "^\\*julia.*\\*$" :ttl nil) + (unless (modulep! +snail) + (set-popup-rule! "^\\*julia.*\\*$" :ttl nil)) (when (modulep! :ui workspaces) (defadvice! +julia--namespace-repl-buffer-to-workspace-a (&optional executable-key suffix)